Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Cairo compatibility #1343

Merged
merged 2 commits into from
Nov 16, 2019
Merged

Conversation

CiaranOMara
Copy link
Contributor

@CiaranOMara CiaranOMara commented Nov 9, 2019

This PR resolves dependencies for #1339, closes #1320 and also closes #1324.

@bjarthur
Copy link
Member

the docs have repeatedly failed to pass CI with his PR. i've restarted multiple times and get the same "stalled build" error. does this work for you locally?

worth noting that CategoricalArrays is now on v0.7, and Gadfly/Project.toml only lists 0.5.

@codecov-io
Copy link

codecov-io commented Nov 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6d68260). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1343   +/-   ##
=========================================
  Coverage          ?   90.12%           
=========================================
  Files             ?       36           
  Lines             ?     3940           
  Branches          ?        0           
=========================================
  Hits              ?     3551           
  Misses            ?      389           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d68260...7a354af. Read the comment docs.

@CiaranOMara
Copy link
Contributor Author

My Travis build also stalled in the same spot.

However, the documentation did build locally.
image

Albeit, it took a while. I've prefixed the build with travis_wait (I may have put it in the wrong spot), which should let it keep running.

@Mattriks
Copy link
Member

Does your local build of the docs use Compose master?

@CiaranOMara
Copy link
Contributor Author

CiaranOMara commented Nov 10, 2019

No it did not. It used the 0.7.4 release.
image

@CiaranOMara
Copy link
Contributor Author

The difference that I'm aware of is that locally I used Julia v1.2 to build the doc instead of Julia v1.0.

This Gadfly documentation build with Julia 1.2 got through in this Travis job.

@CiaranOMara
Copy link
Contributor Author

Commit a283bec got through in ~18min with travis_wait.

@bjarthur bjarthur merged commit 2011796 into GiovineItalia:master Nov 16, 2019
@Mattriks Mattriks mentioned this pull request Nov 16, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants